Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented CI Workflow for visual regression testing using Argos and Playwright. #100

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Implemented CI Workflow for visual regression testing using Argos and Playwright. #100

merged 4 commits into from
Oct 30, 2023

Conversation

devilkiller-ag
Copy link
Contributor

Summary of Changes

Implemented CI Workflow for visual regression testing using Argos and Playwright.

Related Issue

Closes #99

Checklist

  • I have read and followed the project's contribution guidelines, including code style and commit message conventions.
  • My code is well-documented, and I've updated relevant documentation.
  • I have added or updated test cases to ensure the code's functionality.
  • I have tested these changes on my local environment.
  • All tests pass, and there are no new linting errors.
  • I have reviewed and proofread my code and the changes.
  • The branch is up-to-date with the base branch.

Reviewer(s)

@hexsecs

@hexsecs
Copy link
Member

hexsecs commented Oct 26, 2023

@devilkiller-ag - I think we might be missing something here. My understanding is that there is github workflow created for this also.
See...
https://docusaurus.io/blog/upgrading-frontend-dependencies-with-confidence-using-visual-regression-testing
https://github.com/slorber/docusaurus-argos-example

@devilkiller-ag
Copy link
Contributor Author

Hi @hexsecs, Yeah I noticed that we missed connecting this repo with Argos (https://argos-ci.com/docs/github). I think this has to be done by project owner.

@hexsecs
Copy link
Member

hexsecs commented Oct 27, 2023

@devilkiller-ag to get this working we need a workflow added to the repository also. See the example here...
https://github.com/slorber/docusaurus-argos-example

@devilkiller-ag
Copy link
Contributor Author

@devilkiller-ag to get this working we need a workflow added to the repository also. See the example here...
https://github.com/slorber/docusaurus-argos-example

Okay Sure I will check it out

@devilkiller-ag
Copy link
Contributor Author

@hexsecs I have added the workflow now. Kindly check it out!

Copy link
Member

@hexsecs hexsecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We finally merged the docusaurus code into the main branch recently. Currently your actions are set up to act on main. This is fine and actually what we want, however the pull request is against the uptane_docusaurus branch. Can you fix to reflect the main branch? If it is easier you can cancel the pull and resubmit against main.

@Abhijay007
Copy link
Collaborator

Abhijay007 commented Oct 30, 2023 via email

@hexsecs hexsecs changed the base branch from uptane_docusaurus to main October 30, 2023 16:08
Copy link
Member

@hexsecs hexsecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to change the merge into branch myself. Looks good thanks!

@hexsecs hexsecs merged commit 0c677de into uptane:main Oct 30, 2023
1 check passed
@devilkiller-ag devilkiller-ag deleted the ag_dev branch October 30, 2023 16:15
@devilkiller-ag
Copy link
Contributor Author

Thanks @hexsecs 😊

@devilkiller-ag devilkiller-ag changed the title Ag dev Implemented CI Workflow for visual regression testing using Argos and Playwright. Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CI Workflow for visual regression testing
3 participants